Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Apr 16, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

Current CI reports the error as follow:

error[E0061]: this method takes 3 arguments but 2 arguments were supplied
   --> datafusion/optimizer/src/test/mod.rs:131:42
    |
131 |         Analyzer::with_rules(vec![rule]).execute_and_check(plan, &options)?;
    |                                          ^^^^^^^^^^^^^^^^^---------------- an argument is missing
    |
note: associated function defined here
   --> datafusion/optimizer/src/analyzer/mod.rs:83:12
    |
83  |     pub fn execute_and_check<F>(
    |            ^^^^^^^^^^^^^^^^^
84  |         &self,
85  |         plan: &LogicalPlan,
    |         ------------------
86  |         config: &ConfigOptions,
    |         ----------------------
87  |         mut observer: F,
    |         ---------------
help: provide the argument
    |
131 |         Analyzer::with_rules(vec![rule]).execute_and_check(plan, &options, /* observer */)?;
    |                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

https://github.com/apache/arrow-datafusion/actions/runs/4715203170/jobs/8362040848?pr=5980

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the optimizer Optimizer rules label Apr 16, 2023
@viirya viirya changed the title Fix compilation error Minor: Fix compilation error Apr 16, 2023
@viirya
Copy link
Member Author

viirya commented Apr 16, 2023

cc @alamb

Copy link
Contributor

@scsmithr scsmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran into this too.

@yjshen yjshen merged commit 303d149 into apache:main Apr 17, 2023
@viirya
Copy link
Member Author

viirya commented Apr 17, 2023

Thanks @yjshen

@viirya
Copy link
Member Author

viirya commented Apr 17, 2023

Thanks @scsmithr too

@alamb
Copy link
Contributor

alamb commented Apr 17, 2023

Thanks @viirya -- sorry about that. Maybe it is time to enable github merge queue to avoid such problems 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optimizer Optimizer rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants