Minor: port more create_drop table tests to sqllogictests #6031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
waynexia
reviewed
Apr 17, 2023
Comment on lines
+454
to
+459
| statement ok | ||
| CREATE EXTERNAL TABLE IF NOT EXISTS aggregate_simple STORED AS CSV WITH HEADER ROW LOCATION 'tests/data/aggregate_simple.csv' |
Member
There was a problem hiding this comment.
According to the previous cases I think we need to create this table again without IF NOT EXIST and expect an error
Contributor
Author
There was a problem hiding this comment.
fixed,thanks again.
CREATE EXTERNAL TABLE
need to check recreate the same EXTERNAL table
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
jiangzhx
force-pushed
the
move_create_drop_to_sqllogictest
branch
from
c2c5969 to
6056ce6
Compare
Member
|
link to #4495 |
r4ntix
approved these changes
Apr 18, 2023
Contributor
|
Thank you all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?