reuse alias map in aggregate logical planning and refactor position resolution #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimexist
changed the title
alamb
approved these changes
Jun 23, 2021
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @jimexist this looks like a nice cleanup -- can you confirm my understanding that this is a refactoring only (aka no behavior change)?
It looks like the PR stops (re)computing extract_aliases by doing so once and reusing the results
Member
Author
yes
yes and i believe all untouched unit tests and integration tests shall vet for that |
Contributor
I agree |
jimexist
force-pushed
the
aggregate-reuse-alias-map
branch
from
ba6102f to
a40f0b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
reuse alias map in aggregate logical planning and refactor position resolution
Are there any user-facing changes?