Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Apr 20, 2023

Which issue does this PR close?

Related to #6042. Follow on to #6044

Rationale for this change

I often use rust_lint.sh to ensure my PR will pass CI.

What changes are included in this PR?

Add a rust_docs.sh script so that ./dev/rust_lint.sh also runs the newly added check in #6044

Are these changes tested?

I tested them manually

Are there any user-facing changes?

No

@alamb alamb added the development-process Related to development process of DataFusion label Apr 20, 2023
@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates sql SQL Planner labels Apr 20, 2023
@alamb alamb changed the title Update rust_lint.sh to include cargo doc Update rust_lint.sh to include newly added cargo doc check Apr 20, 2023
@alamb alamb force-pushed the alamb/rust_lint_update branch from 552d06a to 1594ac8 Compare April 20, 2023 12:26
@alamb alamb removed sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate labels Apr 20, 2023
@alamb alamb marked this pull request as ready for review April 20, 2023 12:27
@alamb alamb closed this Apr 20, 2023
@alamb alamb reopened this Apr 20, 2023
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@waynexia waynexia merged commit 8bb971d into apache:main Apr 21, 2023
@alamb alamb deleted the alamb/rust_lint_update branch April 21, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants