Skip to content

Conversation

@parkma99
Copy link
Contributor

@parkma99 parkma99 commented May 6, 2023

Which issue does this PR close?

Closes #6214

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels May 6, 2023
Copy link
Contributor

@r4ntix r4ntix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @parkma99 👍

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @parkma99 and @r4ntix for the review

@alamb alamb merged commit 4b041b5 into apache:main May 8, 2023
@parkma99 parkma99 deleted the unicode branch May 9, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port tests in unicode.rs to sqllogictest

3 participants