Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented May 8, 2023

Which issue does this PR close?

N/A

Rationale for this change

I noticed this while reviewing #6269 from @viirya

#3387 has been closed so there is no need for this workaround any longer

What changes are included in this PR?

remove workaround

Are these changes tested?

covered by existing tests

Are there any user-facing changes?

@github-actions github-actions bot added the logical-expr Logical plan and expressions label May 8, 2023
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I closed the issue but forgot the remove this code. Thanks @alamb

@alamb alamb marked this pull request as ready for review May 8, 2023 17:36
@alamb alamb changed the title Remove dead code for casting dictionaries minor: Remove dead code for casting dictionaries May 8, 2023
@alamb alamb merged commit a420ef8 into apache:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logical-expr Logical plan and expressions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants