Skip to content

minor: Remove dead code for casting dictionaries #6286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
May 8, 2023
Merged

minor: Remove dead code for casting dictionaries #6286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions datafusion/expr/src/type_coercion/binary.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,16 +504,6 @@ fn mathematics_numerical_coercion(
return None;
};

// same type => all good
// TODO: remove this
// bug: https://github.com/apache/arrow-datafusion/issues/3387
if lhs_type == rhs_type
&& !(matches!(lhs_type, DataType::Dictionary(_, _))
|| matches!(rhs_type, DataType::Dictionary(_, _)))
{
return Some(lhs_type.clone());
}

// these are ordered from most informative to least informative so
// that the coercion removes the least amount of information
match (lhs_type, rhs_type) {
Expand Down