Skip to content

Conversation

@jackwener
Copy link
Member

@jackwener jackwener commented May 9, 2023

Which issue does this PR close?

related #2175
close #3807.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules sql SQL Planner labels May 9, 2023
@jackwener jackwener marked this pull request as draft May 9, 2023 11:58
@jackwener jackwener marked this pull request as ready for review May 9, 2023 13:46
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jackwener

@alamb alamb merged commit c7f5183 into apache:main May 9, 2023
@jackwener jackwener deleted the place_holder branch May 10, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules sql SQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Expr enum consistent with LogicalPlan by using structs for each variant

2 participants