Port some tests in joins.rs to sqllogictest #6306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
Contributor
Author
|
Still having many tests in joins.rs not porting to sqllogictest😊😊 |
alamb
approved these changes
May 11, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @parkma99 -- epic work 🦾
I reviewed all the tests and they look ported very nicely me. The only thing I suggest is keeping a few of the comments that provided context about the tests which I have added as suggestions to this PR
alamb
approved these changes
May 11, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @parkma99 -- epic work 🦾
I reviewed all the tests and they look ported very nicely me. The only thing I suggest is keeping a few of the comments that provided context about the tests which I have added as suggestions to this PR
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
related #6302
Rationale for this change
What changes are included in this PR?
Port
create_join_context_unbalanced tests,create_join_context_with_nullsand somecreate_join_contexttests in joins.rs to sqllogictestAre these changes tested?
Are there any user-facing changes?