Skip to content

Conversation

@jonahgao
Copy link
Member

@jonahgao jonahgao commented May 11, 2023

Which issue does this PR close?

Closes #6333

Rationale for this change

The update to remainder is incorrect when when_match contains NULLs.

Treat NULLs as false.

Are these changes tested?

YES

Are there any user-facing changes?

No

@github-actions github-actions bot added the physical-expr Changes to the physical-expr crates label May 11, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @byteink -- this makes sense to me

@alamb alamb merged commit 7696aa5 into apache:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Case expression incorrectly handles nulls

2 participants