Fix expected output #6353
Merged
Fix expected output #6353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
commented
May 15, 2023
| logical_plan after simplify_expressions SAME TEXT AS ABOVE | ||
| logical_plan after unwrap_cast_in_comparison SAME TEXT AS ABOVE | ||
| logical_plan after replace_distinct_aggregate SAME TEXT AS ABOVE | ||
| logical_plan after decorrelate_where_exists SAME TEXT AS ABOVE |
Contributor
Author
There was a problem hiding this comment.
This is the real change (as two rules were combined)
The rest of this PR is a consequence of running cargo test --test sqllogictests -- --complete and checking in the result
r4ntix
approved these changes
May 15, 2023
Contributor
Author
|
Thanks @r4ntix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
I believe #6271 had a logical merge conflict
Rationale for this change
CI is failing on master. It should be fixed
What changes are included in this PR?
update sqllogictest output
Are these changes tested?
Are there any user-facing changes?