Skip to content

Support is [not] distinct from for binaryarray types#6394

Merged
alamb merged 4 commits intomainfrom
support-is-distinct-from-for-binaryarray
May 22, 2023
Merged

Support is [not] distinct from for binaryarray types#6394
alamb merged 4 commits intomainfrom
support-is-distinct-from-for-binaryarray

Conversation

@Dandandan
Copy link
Copy Markdown
Contributor

@Dandandan Dandandan commented May 19, 2023

Which issue does this PR close?

Closes #6395

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions Bot added core Core DataFusion crate physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt) labels May 19, 2023
Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR has updated the testing submodule pin somehow -- I wonder if that was intentional 🤔

Screenshot 2023-05-19 at 3 10 17 PM

@Dandandan Dandandan force-pushed the support-is-distinct-from-for-binaryarray branch from e636bbd to 87c69c5 Compare May 19, 2023 20:12
@Dandandan Dandandan force-pushed the support-is-distinct-from-for-binaryarray branch from 87c69c5 to 296b067 Compare May 19, 2023 20:14
@Dandandan
Copy link
Copy Markdown
Contributor Author

Thanks @alamb is solved now :)

@Dandandan Dandandan requested a review from thinkharderdev May 22, 2023 12:50
Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @Dandandan

@alamb alamb merged commit 53d6987 into main May 22, 2023
Dandandan added a commit to coralogix/arrow-datafusion that referenced this pull request May 23, 2023
* Support is distinc from binary

* Add tests

* Tests

* Fix test

---------

Co-authored-by: Daniël Heres <daniel.heres@coralogix.com>
joroKr21 pushed a commit to coralogix/arrow-datafusion that referenced this pull request Jun 1, 2023
* Support is distinc from binary

* Add tests

* Tests

* Fix test

---------

Co-authored-by: Daniël Heres <daniel.heres@coralogix.com>
@alamb alamb deleted the support-is-distinct-from-for-binaryarray branch June 22, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is Distinct from doesn't support binary array

2 participants