Fix Select Into with Order By and Limit#6442
Merged
mustafasrepo merged 2 commits intoapache:mainfrom May 25, 2023
synnada-ai:feature/fix-select-into
Merged
Fix Select Into with Order By and Limit#6442mustafasrepo merged 2 commits intoapache:mainfrom synnada-ai:feature/fix-select-into
mustafasrepo merged 2 commits intoapache:mainfrom
synnada-ai:feature/fix-select-into
Conversation
github-actions
Bot
added
core
alamb
approved these changes
May 25, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks like a good change to me -- thank you @berkaysynnada
jackwener
approved these changes
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6440.
Rationale for this change
Select Into queries with
order byorlimitstatements give an error while creating an initial physical plan.What changes are included in this PR?
In SELECT INTO queries, CreateMemoryTable plan was built before order by and limit planning. However, in CREATE TABLE AS queries, CreateMemoryTable is built with the finalized logical plan (after order by and limit statements are included the plan). Select Into follows the same planning order now.
Are these changes tested?
Yes.
Are there any user-facing changes?