Ordering Equivalence Builder#6452
Merged
mustafasrepo merged 25 commits intoapache:mainfrom May 27, 2023
synnada-ai:feature/orderin_equivalence_vec
Merged
Ordering Equivalence Builder#6452mustafasrepo merged 25 commits intoapache:mainfrom synnada-ai:feature/orderin_equivalence_vec
mustafasrepo merged 25 commits intoapache:mainfrom
synnada-ai:feature/orderin_equivalence_vec
Conversation
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Conflicts: # datafusion/core/src/physical_plan/windows/mod.rs # datafusion/physical-expr/src/equivalence.rs
github-actions
Bot
added
core
alamb
approved these changes
May 26, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @mustafasrepo this looks like a nice improvement to me. I am playing around locally with trying to move more of the equivalence calculations into this builder
Comment on lines
+333
to
+335
| pub fn ordering_equivalence(&self) -> OrderingEquivalenceProperties { | ||
| self.ordering_eq_properties.clone() | ||
| } |
Contributor
There was a problem hiding this comment.
I think you could save a clone here if it took self by reference:
Suggested change
| pub fn ordering_equivalence(&self) -> OrderingEquivalenceProperties { | |
| self.ordering_eq_properties.clone() | |
| } | |
| pub fn build(self) -> OrderingEquivalenceProperties { | |
| self.ordering_eq_properties | |
| } |
Contributor
Author
There was a problem hiding this comment.
Fixed it, thanks for the suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
As suggested by @alamb in the discussion. Changing ordering equivalence creation to builder style would encapsulate the logic to
equivalence.rsfile. By this way we can increase maintainability of the codebase.This PR implements this suggestion.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?