Substrait: Support Expr::ScalarFunction#6471
Merged
alamb merged 5 commits intoapache:mainfrom May 30, 2023
Merged
Conversation
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
alamb
reviewed
May 28, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @jayzhan211
cc @waynexia
| } | ||
|
|
||
| fn name_to_scalar_function(name: &str) -> Result<BuiltinScalarFunction> { | ||
| match name { |
Contributor
There was a problem hiding this comment.
I wonder if you can use FromStr for this: https://github.com/apache/arrow-datafusion/blob/2bbc5063fefcc51ca98300e74b1bbc19ef4827ad/datafusion/expr/src/built_in_function.rs#L445-L458
So like
let func = BuiltinScalarFunction::from_str(name)?;Or perhaps you need a different list of names to match what is in substrait 🤔
Contributor
|
cc @nseekhao |
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Contributor
Author
|
Thanks for your review, code is updated and ready for review. |
waynexia
approved these changes
May 30, 2023
Member
waynexia
left a comment
waynexia
left a comment
There was a problem hiding this comment.
Generally LGTM, thanks 👍
We can also extend scalar UDF in ScalarFunctionType later
Contributor
|
LGTM. Thank you so much, @jayzhan211 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6411.
Rationale for this change
What changes are included in this PR?
Currently, we had supported Subtrait::ScalarFunction to DF::BinaryExpr when args len is 2. Now, we support Subtrait::ScalarFunction to DF::ScalarFunction for arbitrary args len. Use name to determine Operator or ScalarFunction to transform for two args cases.
Are these changes tested?
Test roundtrip_logical_plan
Are there any user-facing changes?