Skip to content

Add serde for DROP VIEW#6499

Merged
alamb merged 4 commits intomainfrom
add_drop_view_serde
Jun 1, 2023
Merged

Add serde for DROP VIEW#6499
alamb merged 4 commits intomainfrom
add_drop_view_serde

Conversation

@Dandandan
Copy link
Copy Markdown
Contributor

@Dandandan Dandandan commented May 31, 2023

Which issue does this PR close?

Closes #6500

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@Dandandan Dandandan changed the title Add serde for drop view Add serde for DROP VIEW May 31, 2023
Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend we add a test for this code

I think this PR should have a test before being merged.

@alamb alamb merged commit 40b6565 into main Jun 1, 2023
@alamb alamb deleted the add_drop_view_serde branch June 1, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Serde for DROP VIEW

2 participants