Minor: Clean up uses to point at real crates#6515
Merged
alamb merged 2 commits intoapache:mainfrom Jun 2, 2023
Merged
Conversation
alamb
commented
Jun 1, 2023
| use crate::execution::context::TaskContext; | ||
| use crate::execution::memory_pool::proxy::{RawTableAllocExt, VecAllocExt}; | ||
| use crate::execution::memory_pool::{MemoryConsumer, MemoryReservation}; | ||
| use datafusion_execution::TaskContext; |
Contributor
Author
There was a problem hiding this comment.
this is the core of the change -- use the actual dependencies rather than backward compatible pub use's
alamb
commented
Jun 1, 2023
| pub mod runtime_env; | ||
| mod task; | ||
|
|
||
| pub use disk_manager::DiskManager; |
Contributor
Author
There was a problem hiding this comment.
moved from the backwards compatibility crates
tustvold
approved these changes
Jun 1, 2023
Contributor
Author
|
This one I think is non controversial so merging it in now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is part of #1754
Rationale for this change
I want to decouple physical_plan from the core datafusion library -- I have already removed most of the actual dependencies, but there are still some dependencies that look real (because they do
use crate::execution:...) but are actual using a re-export.What changes are included in this PR?
This updates the
usestatements inphysical_planto not use the backward compatible aliases but the actual new locationsAre these changes tested?
covered by existing tests
Are there any user-facing changes?
No