feat: DISTINCT bitwise and boolean aggregate functions
#6581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
reviewed
Jun 7, 2023
| ---- | ||
| 1632751011 5960911605712039654 148 54789 169634700 | ||
|
|
||
| # csv_query_bit_xor_distinct |
Contributor
There was a problem hiding this comment.
Suggested change
| # csv_query_bit_xor_distinct | |
| # csv_query_bit_xor_distinct (should be different than above) |
| SELECT bit_xor(distinct c5 % 2) FROM aggregate_test_100 | ||
| ---- | ||
| -2 | ||
|
|
Contributor
There was a problem hiding this comment.
even though, as you note,BIT_AND(DISTINCT), BIT_OR(DISTINCT), BOOL_AND(DISTINCT) and BOOL_OR(DISTINCT) are the same as their non distinct versions, I think we should still add SQL coverage so that we don't accidentally break the feature during some future refactoring
|
|
||
| /// Expression for a BIT_XOR(DISTINCT) aggregation. | ||
| #[derive(Debug, Clone)] | ||
| pub struct DistinctBitXor { |
Contributor
There was a problem hiding this comment.
I wonder if it is possible to avoid duplicated code for distinct aggregates -- they are all basically doing the same thing 🤔
alamb
approved these changes
Jun 8, 2023
jayzhan211
pushed a commit
to jayzhan211/datafusion
that referenced
this pull request
Jun 12, 2023
* feat: distinct bitwise and boolean aggregate functions * feat: add distinct sqllogictests for other bitwise and boolean aggregate functions * feat: improve docs for csv_query_bit_xor_distinct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #6276
Rationale for this change
We can use
BIT_AND(DISTINCT),BIT_OR(DISTINCT),BOOL_AND(DISTINCT)andBOOL_OR(DISTINCT)but it won't have any effect, so the mechanism of action remains the same. Another case isBIT_XOR(DISTINCT), for this function the results with the default version will be different.For example (where
a=[4, 7, 4, 7, 15]):What changes are included in this PR?
All bitwise and boolean aggregate functions start to support
DISTINCTcases.Are these changes tested?
Yes
Are there any user-facing changes?
Yes