Skip to content

Ballista: Avoid sleeping between polling for tasks #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Ballista: Avoid sleeping between polling for tasks #698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ballista/rust/executor/src/execution_loop.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ pub async fn poll_loop(
let task_status: Vec<TaskStatus> =
sample_tasks_status(&mut task_status_receiver).await;

// Keeps track of whether we received task in last iteration
// to avoid going in sleep mode between polling
let mut active_job = false;

let poll_work_result: anyhow::Result<
tonic::Response<PollWorkResult>,
tonic::Status,
Expand All @@ -73,14 +77,18 @@ pub async fn poll_loop(
task,
)
.await;
active_job = true;
} else {
active_job = false;
}
}
Err(error) => {
warn!("Executor registration failed. If this continues to happen the executor might be marked as dead by the scheduler. Error: {}", error);
}
}

tokio::time::sleep(Duration::from_millis(250)).await;
if !active_job {
tokio::time::sleep(Duration::from_millis(100)).await;
}
}
}

Expand Down