Minor: Further Increase stack_size to prevent roundtrip_deeply_nested test stack overflow #7208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Aug 5, 2023
Contributor
|
Thanks @devinjdangelo |
avantgardnerio
pushed a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Aug 21, 2023
… test stack overflow (apache#7208) * fix stack overflow abort * doubling stack size is enough (cherry picked from commit 56c8b5b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
On my local dev machine,
cargo test roundtrip_deeply_nestedaborts with a stack overflow error. Increasing thestack_sizevalue in the test fixes the problem. It is unclear to me why this is required for me locally, but does not affect the CI pipeline (or presumably other devs).What changes are included in this PR?
Increase stack_size to 20_000_000 from previous value of 10_000_000.
Are these changes tested?
N/A
Are there any user-facing changes?
No.