Minor: fix some parquet writer session level defaults #7295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
approved these changes
Aug 16, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @devinjdangelo -- I added some documentation suggestions but I also think we could do them as a follow on PR
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
clarify meaning of null in session default writer settings Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Contributor
|
Thanks again @devinjdangelo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
I noticed that with the current default parquet writer settings, writing a single row to a parquet file results in a file over 4MB in size. Some of the config values are being set to explicit values (e.g. plain encoding) rather than the default setting in the
parquetcrate which is to leave these values asNone.What changes are included in this PR?
This PR makes the session level default for these values
Noneto match the behavior of theparquetcrate. After doing so, parquet files are now a minimum of 4KB rather than 4MB.Are these changes tested?
Yes by existing tests.
Are there any user-facing changes?
Better default parquet writer settings