Fix Unnest for array aggregations. #7300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Aug 16, 2023
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn unnest_array_agg() -> Result<()> { |
Contributor
There was a problem hiding this comment.
I verified that this test covers the code in this PR by running it without the code changes locally. It fails as expected 💯
---- dataframe::unnest_array_agg stdout ----
Error: ArrowError(ComputeError("concat requires input of at least one array"))
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7299.
Rationale for this change
When unnesting a list array created by
array_aggaggregation fails with error:This PR adds code to prevent
concatfrom being called with an empty array during unnesting.What changes are included in this PR?
This PR adds code to prevent
concatfrom being called with an empty array during unnesting.This PR also removes the
list_lengthsworkaround fixed in arrow #4517.Are these changes tested?
Yes added a test for the failing scenario.
Are there any user-facing changes?
No