Skip to content

Minor: Followup tasks for nanvl #7311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Aug 16, 2023
Merged

Minor: Followup tasks for nanvl #7311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions datafusion/physical-expr/src/math_expressions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,9 +1057,9 @@ mod tests {
Arc::new(Float64Array::from(vec![5.0, 6.0, f64::NAN, f64::NAN])), // x
];

let result = nanvl(&args).expect("failed to initialize function atan2");
let result = nanvl(&args).expect("failed to initialize function nanvl");
let floats =
as_float64_array(&result).expect("failed to initialize function atan2");
as_float64_array(&result).expect("failed to initialize function nanvl");

assert_eq!(floats.len(), 4);
assert_eq!(floats.value(0), 1.0);
Expand All @@ -1075,9 +1075,9 @@ mod tests {
Arc::new(Float32Array::from(vec![5.0, 6.0, f32::NAN, f32::NAN])), // x
];

let result = nanvl(&args).expect("failed to initialize function atan2");
let result = nanvl(&args).expect("failed to initialize function nanvl");
let floats =
as_float32_array(&result).expect("failed to initialize function atan2");
as_float32_array(&result).expect("failed to initialize function nanvl");

assert_eq!(floats.len(), 4);
assert_eq!(floats.value(0), 1.0);
Expand Down
1 change: 1 addition & 0 deletions docs/source/user-guide/expressions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ expressions such as `col("a") + col("b")` to be used.
| log(base, x) | logarithm of x for a particular base |
| log10(x) | base 10 logarithm |
| log2(x) | base 2 logarithm |
| nanvl(x, y) | returns x if x is not NaN otherwise returns y |
| pi() | approximate value of π |
| power(base, exponent) | base raised to the power of exponent |
| radians(x) | converts degrees to radians |
Expand Down