Add internal_err error macros. Part 2
#7321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
Contributor
Author
alamb
approved these changes
Aug 18, 2023
| Err(DataFusionError::Internal( | ||
| "function left requires compilation with feature flag: unicode_expressions.".to_string() | ||
| )), | ||
| internal_err!( |
Contributor
There was a problem hiding this comment.
This wasn't caused by this PR, but it almost seems like these should be plan_err! rather than internal_err! (though maybe they are internal because this should have been checked earlier
|
|
||
| SQLExpr::ArrayIndex { obj, indexes } => { | ||
| let expr = self.sql_expr_to_logical_expr(*obj, schema, planner_context)?; | ||
| let expr = |
Contributor
There was a problem hiding this comment.
it is interesting that this file was reformatted without changes 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #6740
#7115
#7293
Closes #.
Rationale for this change
Add
internal_err!error macro to replaceDatafusionError::Internalwith more concise code and make error handling in single placeWhat changes are included in this PR?
Are these changes tested?
Existing tests
Are there any user-facing changes?
No