Minor: Move shared testing code into datafusion_common #7334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Aug 18, 2023
| }; | ||
| } | ||
|
|
||
| /// Returns the arrow test data directory, which is by default stored |
Contributor
Author
There was a problem hiding this comment.
this is moved code -- no changes
| } | ||
|
|
||
| /// Get the schema for the aggregate_test_* csv files with an additional filed not present in the files. | ||
| fn aggr_test_schema_with_missing_col() -> SchemaRef { |
Contributor
Author
There was a problem hiding this comment.
I moved this out as this is the only place it is used and rewrote it to append the column explicitly rather than copy/paste with one line difference
yjshen
approved these changes
Aug 18, 2023
viirya
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Final prep for #1754
Rationale for this change
physical plan can't depend on code in core when I pull it out
What changes are included in this PR?
move some functions from
datafusion/core/src/test_util.rstodatafusion/common/src/test_util.rsAre these changes tested?
covered by existing tests
Are there any user-facing changes?
No -- I left backward compatible
pub use