fix: union_distinct shouldn't remove child distinct #7346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I will add other rule after this PR, such as |
alamb
approved these changes
Aug 21, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Makes sense to me -- it is somewhat interesting that there are no end to end plan explain changes. Thanks @jackwener
I looked into it and it seems like this function is not called via the SQL planner, only via the DataFrame API
https://github.com/search?q=repo%3Aapache%2Farrow-datafusion%20%20union_distinct&type=code
|
|
||
| /// Apply a union, removing duplicate rows | ||
| pub fn union_distinct(self, plan: LogicalPlan) -> Result<Self> { | ||
| // unwrap top-level Distincts, to avoid duplication |
Contributor
There was a problem hiding this comment.
The key point of this PR is that reshuffling around of DISTINCT should be done as an optimization pass, rather than as part of the builder, if I understand it. This makes sense to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
original code will remove distinct when they are children of union.
But we should't remove them, because
What changes are included in this PR?
union_distinct shouldn't remove child distinct
Are these changes tested?
Are there any user-facing changes?