feat: Allow creating a ValuesExec from record batches #7444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Sep 6, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
I think this looks like a nice addition @scsmithr -- thank you for the contribution (and I apologize for the delay in review).
It looks like there is one CI failure https://github.com/apache/arrow-datafusion/actions/runs/6016911160/job/16322230592?pr=7444 due to use of deprecated features in chrono, but that appears to have been fixed in #7451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Allows reconstructing a
ValuesExecfrom a schema and vector of record batches.The use case here is being able to completely serialize a physical plan that would get produced from a statement like
insert into my_table values (...).Serialization of
ValuesExecis not included in this PR. My plan for serialization was to just IPC encode the batches. If that sounds reasonable, I can follow up with a PR adding that to theprotocrate.What changes are included in this PR?
Are these changes tested?
Adds a couple small tests.
Are there any user-facing changes?
Adds additional functions for
ValuesExec, but no change in behavior.