Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Aug 3, 2021

Which issue does this PR close?

Closes #.

Rationale for this change

Currently only datafusion only supports string, numeric and timestamp types for min max aggregation. This is to add date types to make it more complete.

What changes are included in this PR?

Are there any user-facing changes?

@viirya
Copy link
Member Author

viirya commented Aug 3, 2021

cc @houqp

Copy link
Member

@houqp houqp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @viirya !

Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dandandan Dandandan merged commit 15ea3b9 into apache:master Aug 3, 2021
@viirya
Copy link
Member Author

viirya commented Aug 3, 2021

Thank you @houqp @Dandandan !

@viirya viirya deleted the max_min_date branch August 3, 2021 07:09
@houqp houqp added the enhancement New feature or request label Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants