Refactor min/max value update in Parquet statistics#9120
Merged
alamb merged 2 commits intoapache:mainfrom Feb 5, 2024
Merged
Conversation
Jefffrey
approved these changes
Feb 4, 2024
Contributor
Jefffrey
left a comment
Jefffrey
left a comment
There was a problem hiding this comment.
Nice refactoring 👍
Left some tips to see if it's possible to simplify it even further
| { | ||
| if let Some(max_value) = &mut max_values[i] { | ||
| max_value | ||
| .update_batch(&[Arc::new(Float64Array::from(vec![Some(*s.max())]))]) |
Contributor
There was a problem hiding this comment.
Suggested change
| .update_batch(&[Arc::new(Float64Array::from(vec![Some(*s.max())]))]) | |
| .update_batch(&[Arc::new(Float64Array::from(vec![*s.max()]))]) |
I think this also works? Goes for the other branches too
| return; | ||
| } | ||
| ParquetStatistics::Boolean(s) | ||
| if DataType::Boolean == *fields[i].data_type() && s.has_min_max_set() => |
Contributor
There was a problem hiding this comment.
Is it possible to pull out the s.has_min_max_set() check from the branches to a once off check at the start of the function? I think ParquetStatistics has an equivalent has_min_max_set() 🤔
alamb
reviewed
Feb 5, 2024
| i: usize, | ||
| stat: &ParquetStatistics, | ||
| ) { | ||
| if !stat.has_min_max_set() { |
alamb
approved these changes
Feb 5, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?