Skip to content

Conversation

@guojidan
Copy link
Contributor

Which issue does this PR close?

Closes #9356 .

Rationale for this change

What changes are included in this PR?

remove check input args type code

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Feb 27, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @guojidan

1

query I
query ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this means that the type reported will be null which I think is fine.

@alamb alamb merged commit 544b3d9 into apache:main Feb 27, 2024
@alamb
Copy link
Contributor

alamb commented Feb 27, 2024

Thanks again @guojidan

@guojidan guojidan deleted the ifnull branch February 28, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: nvl function's return type

2 participants