Minor: Fix document Interval syntax #9542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayzhan211
reviewed
Mar 11, 2024
| | Interval(YearMonth) | | ||
| +-------------------------------------+ | ||
| +---------------------------------------------------------------------+ | ||
| | arrow_typeof(IntervalMonthDayNano("79228162514264337593543950336")) | |
Contributor
Author
There was a problem hiding this comment.
I think it returns the nano second as the result?
If it returns IntervalYearMonth the result will be 1, but now Interval will always return IntervalMonthDayNano.
See #5801
jayzhan211
approved these changes
Mar 11, 2024
comphead
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9525 .
Rationale for this change
As this #9525 (comment) said
And the reason is #5801 but document has not been updated yet.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?