Add tests for filtering, grouping, aggregation of ARRAYs #9695
Conversation
| # Filtering | ||
| ########### | ||
|
|
||
| query error DataFusion error: Arrow error: Invalid argument error: Invalid comparison operation: List\(Field \{ name: "item", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: \{\} \}\) == List\(Field \{ name: "item", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: \{\} \}\) |
There was a problem hiding this comment.
I was actually surprised I couldn't write a basic filter for ARRAYs -- do you know if this is tracked by any ticket @jayzhan211 ?
There was a problem hiding this comment.
No, there is no filed issue with filter. We can open one, it seems like an interesting feature. I think we can utilize logical plan::filter.
There was a problem hiding this comment.
No, there is no filed issue with
filter. We can open one, it seems like an interesting feature. I think we can utilize logical plan::filter.
I was confused with array_filter, maybe we just need to support array types for filterExec 🤔
| # Aggregates | ||
| ########### | ||
|
|
||
| query error Internal error: Min/Max accumulator not implemented for type List |
There was a problem hiding this comment.
We should probably make this at least a nicer error ("Not supported" rather than "internal error")
|
@jayzhan211 I wonder if you would have a few minutes to review this PR sometime? |
* Add tests for filtering, grouping, aggregation of ARRAYs * Update output to correct results
2 participants
Which issue does this PR close?
Related to #9586
Rationale for this change
While working on #9679 I realized that the amount of coverage for
ARRAYs other than the (very extensive) coverage for functions was pretty sparseWhat changes are included in this PR?
Add a new
array_query.sltfile that has basic query patterns for filtering, aggregation, grouping and orderingAre these changes tested?
it is only tests
Are there any user-facing changes?
no