Disable parallel reading for gziped ndjson file #9799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Mar 27, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you for the contribution @Lordworms 🙏
I left a suggestion on how to clean up the code but I don't think it is required to merge this PR.
| async fn test_disable_parallel_for_json_gz() -> Result<()> { | ||
| let config = SessionConfig::new() | ||
| .with_repartition_file_scans(true) | ||
| .with_repartition_file_min_size(0) |
| let repartition_file_min_size = config.optimizer.repartition_file_min_size; | ||
| let repartition_file_min_size = | ||
| if self.file_compression_type == FileCompressionType::GZIP { | ||
| OptimizerOptions::default().repartition_file_min_size |
Contributor
There was a problem hiding this comment.
I wonder it it would be simpler code to return None here
Suggested change
| OptimizerOptions::default().repartition_file_min_size | |
| None |
That way the rest of the code could be left alone.
alamb
changed the title
alamb
reviewed
Mar 27, 2024
| target_partitions: usize, | ||
| config: &datafusion_common::config::ConfigOptions, | ||
| ) -> Result<Option<Arc<dyn ExecutionPlan>>> { | ||
| if self.file_compression_type == FileCompressionType::GZIP { |
alamb
approved these changes
Mar 27, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @Lordworms 🙏
Looks like there is a small CI failure otherwise this PR is ready to go
Dandandan
approved these changes
Mar 27, 2024
Contributor
|
Thanks again @Lordworms and @Dandandan 🙏 |
Lordworms
added a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Apr 1, 2024
* for debug * disable paralle reading for gziped ndjson file * directly return None * delete .gz * fix clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9564
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?