Add non-column expression equality tracking to filter exec #9819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suremarc
approved these changes
Mar 27, 2024
Contributor
suremarc
left a comment
suremarc
left a comment
There was a problem hiding this comment.
Seems reasonable to me. I thought about adding this in my PR but, not knowing this part of the codebase well, I wasn't sure if there would be any knock-on effects or bugs. I like the sqllogictest demonstration as well
comphead
approved these changes
Mar 28, 2024
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
lgtm thanks @mustafasrepo
I was thinking to wrap
(&Arc<dyn PhysicalExpr>, &Arc<dyn PhysicalExpr>)
``` into separate type for readability, but I see it is used with and without lifetimes, not sure if its easily doable then
Contributor
Author
I sent a commit for this solution. I think it is better. Thanks for the suggestion. |
Lordworms
pushed a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Apr 1, 2024
* Add non-column expression equality tracking to filter exec * Minor changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #9812.
Rationale for this change
In the issue #9812. @suremarc recognized that some of the expression in the equality predicate of the
FilterExecis not considered by subsequent stages. since they are lost during analysis. This PR modifiesFilterExecto add support for equality tracking betweenPhysical Exprs (e.g not just betweenColumns).What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?