Minor: Use Expr::apply() instead of inspect_expr_pre()
#9984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
Contributor
I think what we should do is deprecate it -- It could be done in a follow on PR |
Contributor
Author
|
Thanks @alamb for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
inspect_expr_pre()is a specaial wrapper aroundExpr::apply(), but all callsites ofinspect_expr_pre()could useExpr::apply()directly. This PR (toghether with #9913) refactors all callsites ofinspect_expr_pre()so technically it could be removed too. But becauseinspect_expr_pre()is a public function removing it would be a breaking change...