move Kolmogorov-Smirnov test to sqlx dir #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The _test suffix is a bit confusing. In the C++ library (and perhaps in Java too) we called it just Kolmogorov-Smirnov to avoid confusion with test code. Should we name the BQ function without this suffix? |
Contributor
Author
|
However in the core library this is a class with several methods, one of which is test(). This BQ function is really that statistical test. |
AlexanderSaydakov
changed the title
leerho
approved these changes
Aug 22, 2024
Member
|
Anyone that is familiar with K-S knows that it is a test. I don't think we need "test" as a suffix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.