Skip to content

Small fix#98

Merged
leerho merged 1 commit intoapache:masterfrom
geonove:geonove/concurrecncy-fixes
Jan 16, 2026
Merged

Small fix#98
leerho merged 1 commit intoapache:masterfrom
geonove:geonove/concurrecncy-fixes

Conversation

@geonove
Copy link
Contributor

@geonove geonove commented Jan 15, 2026

Small bug fix that I missed in #95

@leerho
Copy link
Member

leerho commented Jan 16, 2026

It would be real helpful if you could explain what the problem was that this fixes. :)
Thanks!

@leerho leerho merged commit 7065bee into apache:master Jan 16, 2026
@geonove
Copy link
Contributor Author

geonove commented Jan 16, 2026

Change was to store the merge trial error into the pre-allocated rank_errors slot for the current trial instead of appending a new element. Previously push_back grew the inner vectors each trial and misaligned the rank/trial grid; now it writes to rank_errors[j++][t], matching the intended rank-by-trial structure (since it the rank error vector is pre-allocated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants