Skip to content

Build python wheels on releases#233

Merged
jmalkin merged 6 commits intomasterfrom
pypi_prep
Aug 26, 2021
Merged

Build python wheels on releases#233
jmalkin merged 6 commits intomasterfrom
pypi_prep

Conversation

@jmalkin
Copy link
Contributor

@jmalkin jmalkin commented Aug 26, 2021

I'm not highly confident, but I think the manual trigger part might not work until the workflow in the main branch specifies that option. Since this seems pretty low risk to merge, I'm proposing we try it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1168927755

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.76%

Totals Coverage Status
Change from base Build 1053852718: 0.0%
Covered Lines: 2178
Relevant Lines: 2348

💛 - Coveralls

@jmalkin
Copy link
Contributor Author

jmalkin commented Aug 26, 2021

the failed checks are that i cancelled the CI job for the push since there was no actual code change (although I kept it for the PR anyway)

Copy link
Contributor

@AlexanderSaydakov AlexanderSaydakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a go

@jmalkin jmalkin merged commit ed37a7a into master Aug 26, 2021
@jmalkin
Copy link
Contributor Author

jmalkin commented Aug 26, 2021

Yay! It worked! If you go to the Github Actions tab and select this workflow, there's now an option to run it manually.

@jmalkin jmalkin deleted the pypi_prep branch August 26, 2021 18:03
@coveralls
Copy link

coveralls commented Nov 23, 2024

Pull Request Test Coverage Report for Build 1168927755

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+5.2%) to 97.927%

Totals Coverage Status
Change from base Build 1053852718: 5.2%
Covered Lines: 7417
Relevant Lines: 7574

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants