Theta and Tuple sketch setops sync with Java#252
Merged
AlexanderSaydakov merged 3 commits intomasterfrom Dec 10, 2021
Merged
Conversation
Pull Request Test Coverage Report for Build 1551528232
💛 - Coveralls |
jmalkin
reviewed
Dec 3, 2021
| template<typename FwdSketch, typename Sketch> | ||
| CS theta_set_difference_base<EN, EK, CS, A>::compute(FwdSketch&& a, const Sketch& b, bool ordered) const { | ||
| if (a.is_empty() || a.get_num_retained() == 0 || b.is_empty()) return CS(a, ordered); | ||
| if (a.is_empty() || (a.get_num_retained() > 0 && b.is_empty())) return CS(a, true); |
Contributor
There was a problem hiding this comment.
CS(a, true) will return a sorted compact sketch regardless of the value of the ordered input parameter. Not really wrong with a CompactSketch, but depending on usage it may force an unnecessary sort.
Pull Request Test Coverage Report for Build 1523456119Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ported tests from Java, adjusted logic