feat: support value-receiver type summary#129
Open
proost wants to merge 3 commits intoapache:mainfrom
Open
Conversation
…pport-value-type-receiver-tuple-sketch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use tuple sketch a lot. One of teams use tuple sketch extremely. One application has many tuple sketches, that each one has lots of summaries.
So It makes a more than billion live objects in heap. So every GC period, especially Marking phase, go runtime uses too many CPU usages as well as it makes longer stop the world.
So I propose supporting value-type receiver summary using "UpdateFunc".
Idea is simple:
Normally, it is not that burden to allocate millions ~ less than billions live objects in heap. So current interface is ok. Also current interface is easy to use and easy to understand.
Here is benchmark result:
Benchmark code is included in this PR.