-
Notifications
You must be signed in to change notification settings - Fork 11
Switch Murmur3 to faster implementation #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Have you tried to test compatibility with C++ and Java? Even a slightest difference in hash function can make sketches incompatible (disjoint sets despite of the same input) |
|
Checked a few hash output for equality. I am actually thinking of checking back in the serialised output test data, to test for possible change like this. Anyhow, in this case, crc32 for the various generations match with both implementations |
3137624 to
65c977f
Compare
Switch Murmur3 dependency to https://github.com/twmb/murmur3 as it yield better performance than the current one.