Fix SerDe Issue 195#196
Merged
Merged
Conversation
hpx7
reviewed
Apr 18, 2018
|
|
||
| @SuppressWarnings("unused") | ||
| @Test | ||
| public void checkSerDeIssue165() { |
Contributor
|
The fix looks fine to me. Let's rename the test to either checkSerDeIssue195 or, perhaps, something like emptyUnionSerDe and assert a few things about the result. |
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
=========================================
Coverage 93.28% 93.28%
Complexity 4607 4607
=========================================
Files 197 197
Lines 13051 13051
Branches 2142 2142
=========================================
Hits 12173 12173
Misses 190 190
Partials 688 688 |
|
Thanks for the quick turnaround! Could we tag a release for this? |
Member
Author
|
Hopefully soon. We need a few days to review all the changes we have made
since the last release.
…On Wed, Apr 18, 2018 at 1:43 PM, Harsh Pandey ***@***.***> wrote:
Thanks for the quick turnaround! Could we tag a release for this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#196 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMV4wpnYYnrV1_ZFpVW91bgc-ZBtGeXUks5tp6WCgaJpZM4TaYvG>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.