Skip to content

The recent additions to KllDoubles classes have been replicated to the KllFloats classes.#540

Merged
leerho merged 1 commit into
masterfrom
replicate_KllDoubles_to_KllFloats
Apr 6, 2024
Merged

The recent additions to KllDoubles classes have been replicated to the KllFloats classes.#540
leerho merged 1 commit into
masterfrom
replicate_KllDoubles_to_KllFloats

Conversation

@leerho
Copy link
Copy Markdown
Member

@leerho leerho commented Apr 5, 2024

Changes by Class:
Note: the corresponding floats and doubles classes match line-by-line to make checking and troubleshooting easier.

/kll/

  • KllDoublesSketch -> KllFloatsSketch

    • Added the Create Sorted View methods from the sorted view class
    • Added the weighted updates + vector update methods
  • KllHeapDoublesSketch -> KllHeapFloatsSketch

    • Added required changes for the vector update methods
  • KllDirectDoublesSketch -> KllDirectFloatsSketch

    • Added required changes for the vector update methods
  • KllDoublesHelper (remove 1 code comment, change 1 variable name) -> KllFloatsHelper

    • Added required changes for the vector update methods
  • KllFloatsSketchSortedView -> quantilescommon/FloatsSketchSortedView //to be shared with REQ

/quantilescommon/

  • DoublesSketchSortedView (1 comment change) -> FloatsSketchSortedView
  • ItemsSketchSortedView (1 comment change)

/test/.../common/

  • TestUtil: (Reference change in 2 places)

/test/.../kll/

  • KllDirectDoublesSketchTest (moved 1 method) -> KllDirectFloatsSketchTest

    • added vector tests
  • KllDoublesSketchSerDeTest -> KllFloatsSketchSerDeTest

    • added line spacings to match
  • KllDoublesSketchTest -> KllFloatsSketchTest

    • added vector tests

/test/.../quantilescommon/

  • CrossCheckQuantilesTest: 4 minor changes required
  • ReflectUtilityTest: 1 minor change required

Specifically weighted updates and vector updates.
@leerho leerho merged commit 56b40e8 into master Apr 6, 2024
@leerho leerho deleted the replicate_KllDoubles_to_KllFloats branch April 6, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants