minor fixes to permit running with Java 25 in restricted mode.#272
Draft
minor fixes to permit running with Java 25 in restricted mode.#272
Conversation
pan3793
reviewed
Feb 5, 2026
| } | ||
| if (p0 > 11) { | ||
| System.err.println( | ||
| "Warning: Java versions > Java 11 can only operate in restricted mode where no off-heap operations are allowed!"); |
Member
There was a problem hiding this comment.
this makes sense, the only concern is, will it be too noisy? maybe add a static field JAVA_VERSION_WARNING_PRINTED as a flag, then we can print it just once.
Member
|
@leerho Awesome, thanks a lot! For the testing plan you suggested at #271 (comment),
It already passes our internal test cases, which are a subset of Apache Spark's official test cases. The most confident approach would be:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although it looks like a lot of changes, it actually consists of the following:
"Warning: Java versions > Java 11 can only operate in restricted mode where no off-heap operations are allowed!"
None of these changes constitute a change in core logic.