Skip to content

minor fixes to permit running with Java 25 in restricted mode.#272

Draft
leerho wants to merge 2 commits into3.0.Xfrom
prepare_3.0.3
Draft

minor fixes to permit running with Java 25 in restricted mode.#272
leerho wants to merge 2 commits into3.0.Xfrom
prepare_3.0.3

Conversation

@leerho
Copy link
Member

@leerho leerho commented Feb 4, 2026

Although it looks like a lot of changes, it actually consists of the following:

  • Checkstyle identified a number of places that should have been qualified with "final".
  • Checkstyle identified a few places in Javadocs where there were unnecessary <p> tags.
  • The GitHub Actions workflows needed to be updated to v4 from v3. These changes were also proposed by @pan3793 in PR Allow to run ds-memory 3.0 on Java 25 #271.
  • The GitHub Action workflow "javadoc.yml" had to be updated because GitHub no longer recognizes the specific JamesIves/github-pages-deploy-action version. The workflow has been converted to a script that does not depend on any 3rd party actions. This is the same script used in DS-Java 9.0.0.
  • The changes in ResourceImpl.java requested by @pan3793 in PR Allow to run ds-memory 3.0 on Java 25 #271. is included here. But in addition, I added a warning message that is issued if the user attempts to run with Java versions greater than 11:
    "Warning: Java versions > Java 11 can only operate in restricted mode where no off-heap operations are allowed!"

None of these changes constitute a change in core logic.

@leerho leerho marked this pull request as draft February 4, 2026 21:53
}
if (p0 > 11) {
System.err.println(
"Warning: Java versions > Java 11 can only operate in restricted mode where no off-heap operations are allowed!");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense, the only concern is, will it be too noisy? maybe add a static field JAVA_VERSION_WARNING_PRINTED as a flag, then we can print it just once.

@pan3793
Copy link
Member

pan3793 commented Feb 5, 2026

@leerho Awesome, thanks a lot!

For the testing plan you suggested at #271 (comment),

Please thoroughly test the new prepare_3.0.3 branch form 272 in your environment to make sure it works with 25 like you expect.

It already passes our internal test cases, which are a subset of Apache Spark's official test cases. The most confident approach would be:

  • deploy 3.0.3-SNAPSHOT to Apache Maven SNAPSHOT repo (or a RC version in Staging repo)
  • I create a PR on the Apache Spark repo to run full test cases with the ds-memory 3.0.3[-SNAPSHOT], the test report will be publicly available, and then it can be reviewed by both the Spark and DataSketches communities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants