Fixes for problems found with 5.0.0-rc1 #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 main changes:
__str__method always calls defaultto_string()and cannot accept parametersto_string()and__str__to all testsNOMINSIZEin CMakeLists.txt to override Nanobind's-Oscompiler flagI'm not sure why a regular call to &sketch_type::to_string sometimes fails. Maybe I need to cast the the right type? But in a few places I used a lambda when it dind't seem necessary just because it worked.
If this looks good, I'll cherry-pick it into the 5.0.x branch.