feat: implement bloom filter #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
reviewed
Dec 31, 2025
tisonkun
reviewed
Dec 31, 2025
tisonkun
reviewed
Dec 31, 2025
tisonkun
reviewed
Dec 31, 2025
tisonkun
approved these changes
Dec 31, 2025
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
LGTM.
+1 for a new release carry all we have now.
freakyzoidberg
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5 .
Adds support for the
BloomFilter, which can be constructed via theBloomFilterBuilder. The implementation should be compatible with the C++ / Java serialisation format.I've added some examples in the rustdoc. I think the library would benefit from having some examples as well. Will create separate tickets.
After we merge this I propose we close #2 and cut a release.