DELTASPIKE-850 Add Weld 3 profile #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deltaspike/parent/code/pom.xml
Outdated
Contributor
There was a problem hiding this comment.
@rsmeral do you know if we can activate it based on the value of weld.version?
Contributor
Author
There was a problem hiding this comment.
OK, I found a way: weld-core-bom is actually a "depchain" and not really a BOM, so we can keep just one Weld profile and by just importing weld-core-bom we can omit all other dependencies (weld-core/weld-core-impl, etc). I'll update the PR.
Contributor
Author
|
After all, all that's needed to make Weld 3 work is to remove explicit weld-core dependency. All the necessary dependencies for any given release (1.x, 2.x, 3.x) are pulled in through weld-core-bom depchain in Weld profile's dependencyManagement. |
Contributor
Author
|
Should not be merged just yet, most likely this will be soon fixed in Weld. |
Contributor
|
PR merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.