Skip to content

DELTASPIKE-1091 created separate profiles for Weld versions, changed…#47

Merged
asfgit merged 1 commit intoapache:masterfrom
manovotn:weldProfileRefactoring
May 2, 2016
Merged

DELTASPIKE-1091 created separate profiles for Weld versions, changed…#47
asfgit merged 1 commit intoapache:masterfrom
manovotn:weldProfileRefactoring

Conversation

@manovotn
Copy link
Copy Markdown
Contributor

… docs accordingly.

I created 3 separate profiles for Weld 1/2/3 respectively.
As all three profiles have part of their build management/dependencies in common, I took those out and put them into a separate profile (Weld-common-setup).

Weld-common-setup is automatically triggered when you use -Dweld.version=... when executing tests (which you do like...all the time? :) ). I couldn't really come up with other solution which would allow to avoid copying this setup into all three profiles. The downside of this is that once you run the tests without -Dweld.version, it will not work.

Last but not least, I modified docs (build.adoc to be more precise) to reflect these changes.

Ideas/comments are welcome!

@manovotn manovotn changed the title DELTASPIKE-1137, created separate profiles for Weld versions, changed… DELTASPIKE-1091, created separate profiles for Weld versions, changed… Apr 28, 2016
@manovotn manovotn force-pushed the weldProfileRefactoring branch from ae16e7a to 1b2b485 Compare April 28, 2016 12:25
@manovotn
Copy link
Copy Markdown
Contributor Author

Corrected the PR and commit name to contain DELTASPIKE-1091.

@manovotn manovotn force-pushed the weldProfileRefactoring branch from 1b2b485 to 930e345 Compare April 28, 2016 13:32
@manovotn manovotn changed the title DELTASPIKE-1091, created separate profiles for Weld versions, changed… DELTASPIKE-1091 created separate profiles for Weld versions, changed… Apr 28, 2016
@rafabene
Copy link
Copy Markdown
Contributor

rafabene commented Apr 29, 2016

When I tried mvn clean install -PWeld1 -Dweld.version=1.1.33.Final as instructed by the docs, the tests of "Test-Control-Module Impl" failed. So I didn't proceed testing the other profiles.

Can you check that @manovotn please? Thanks

@manovotn
Copy link
Copy Markdown
Contributor Author

@rafabene you probably bumped into these issue:
https://issues.apache.org/jira/browse/DELTASPIKE-1137
https://issues.apache.org/jira/browse/DELTASPIKE-1138

Those failures were unrelated to this PR (DS build would fail with any Weld 1 due to FutureableTest).

I can see one of the above issues has been resolved in the meantime, I can try rebasing the PR and running the tests.
Anyway apart from Weld 1, all other versions should work. I will take a closer look at it on Monday and let you know.

@rafabene
Copy link
Copy Markdown
Contributor

I can confirm that Weld2 and Weld3 are working. I rebased the code with master to try your PR but Weld1 still failing.

@manovotn
Copy link
Copy Markdown
Contributor Author

Then I shall take a closer look at it on Monday :-)

@manovotn manovotn force-pushed the weldProfileRefactoring branch from 930e345 to 783f4d3 Compare May 2, 2016 08:33
@manovotn
Copy link
Copy Markdown
Contributor Author

manovotn commented May 2, 2016

@rafabene you were right. Upstream fixed the problem with FutureableTest but there was another glitch.

In deltaspike/modules/test-control, there was yet another Weld profile which added one dependency (org.apache.deltaspike.cdictrl:deltaspike-cdictrl-weld). This dep only seems to be needed for Weld 1.x, other versions pass without it. Hence I refactored it to include this dep only in case Weld 1 is running.

Is it ok now?

@asfgit asfgit merged commit 783f4d3 into apache:master May 2, 2016
@rafabene
Copy link
Copy Markdown
Contributor

rafabene commented May 2, 2016

Thanks @manovotn .

PR merged and document published at: http://deltaspike.apache.org/documentation/build.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants