DELTASPIKE-1091 created separate profiles for Weld versions, changed…#47
Conversation
ae16e7a to
1b2b485
Compare
|
Corrected the PR and commit name to contain DELTASPIKE-1091. |
1b2b485 to
930e345
Compare
|
When I tried Can you check that @manovotn please? Thanks |
|
@rafabene you probably bumped into these issue: Those failures were unrelated to this PR (DS build would fail with any Weld 1 due to FutureableTest). I can see one of the above issues has been resolved in the meantime, I can try rebasing the PR and running the tests. |
|
I can confirm that Weld2 and Weld3 are working. I rebased the code with master to try your PR but Weld1 still failing. |
|
Then I shall take a closer look at it on Monday :-) |
…docs accordingly.
930e345 to
783f4d3
Compare
|
@rafabene you were right. Upstream fixed the problem with In Is it ok now? |
|
Thanks @manovotn . PR merged and document published at: http://deltaspike.apache.org/documentation/build.html |
… docs accordingly.
I created 3 separate profiles for Weld 1/2/3 respectively.
As all three profiles have part of their build management/dependencies in common, I took those out and put them into a separate profile (
Weld-common-setup).Weld-common-setupis automatically triggered when you use-Dweld.version=...when executing tests (which you do like...all the time? :) ). I couldn't really come up with other solution which would allow to avoid copying this setup into all three profiles. The downside of this is that once you run the tests without-Dweld.version, it will not work.Last but not least, I modified docs (
build.adocto be more precise) to reflect these changes.Ideas/comments are welcome!