DELTASPIKE-1185 Allow customization (name, description) of JMX managed...#59
Merged
asfgit merged 1 commit intoapache:masterfrom Jul 22, 2016
Merged
DELTASPIKE-1185 Allow customization (name, description) of JMX managed...#59asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
Hi Xavier, PR looks good. Would you mind rebasing from master? |
| { | ||
| try | ||
| { | ||
| parameterClass = Class.forName("java.lang.reflect.Parameter"); |
Contributor
There was a problem hiding this comment.
This is super useful, we'll be able to start adding named parameter support in repos now.
methods' parameters
Contributor
Author
|
rebased |
Contributor
|
Thanks for the contrib, merged to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Here is a first try at implementing the customization (name + description) of JMX operations' parameters.
I didn't know if it was better to make a new
@JmxParameterannotation or reuse the existing@JmxManaged(which would have needed a newnameattribute).I opted for the first solution but I can change it if needed. In the 2nd solution, adding a new
nameattribute to@JmxManagedcould also allow to override the operation name.Regards,
Xavier