[Bug][GitHub] Switching to GraphQL results in no DORA metrics

[kostas-petrakis]

Search before asking

• I had searched in the issues and found no similar issues.

What happened

The specific issue appears to have been addressed with a fix, as referenced in issue #8383. Since we rely on the provided images, we kindly request the release of a new beta version to incorporate this fix.

What do you expect to happen

Jobs are properly extracted during the pipeline

How to reproduce

• Enable GraphQL for GitHun in Apache Devlake v1.0.2-beta7
• Create a new project with a scope config
• Notice that Jobs are not extracted in the corresponding DB table

Anything else

No response

Version

v1.0.2-beta7

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[kostas-petrakis]

Revisiting this ticket, I tested today the image tag main_250421_0937_b7fca14 which includes the fixes for the extraction of the jobs.
The extraction works as expected, but DORA metrics are not calculated, I am checking the code to see what changed and causes this issue, but currently we are one week in without any DORA metrics.

[kostas-petrakis]

I can confirm that there is a regression, likely related to issue #8233. After testing the image of the specific feature, DORA metrics stopped being calculated.
I tested versions main_250421_0937_b7fca14 , v1.0.2-beta4 and v1.0.2-beta7. While beta4 correctly calculates DORA metrics, beta-7 and main_250421_0937_b7fca14 do not provide any DORA metrics. The issue seems to stem from the generation of cicd_deployment_commits entries, beta-7 and main_250421_0937_b7fca14 are empty, whereas beta-4 contains the relevant entries.
Next, I will conduct a completely new local experiment using beta-7 to determine whether the issue is related to updating the image on an existing deployment or if it is inherent to the code itself.

[kostas-petrakis]

After doing some comparison between the REST and GraphQL extracted jobs, it seems that most likely the issue causing extracted jobs not properly parsed is that the run_id assigned is wrong as it points to the job.
https://github.com/apache/incubator-devlake/blob/main/backend/plugins/github_graphql/tasks/job_extractor.go#L70

[kostas-petrakis]

@klesh I have opened a fix, I kindly ask if we can get this fast in and create a release, as currently DORA calculations are broken for the latest beta.
Unfortunately this will also require a recollection as the existing job entries don't include the proper run id

[kostas-petrakis]

Bumping this as the PR needs some 👀

[klesh]

@d4x1 Can you help releasing a new beta for @kostas-petrakis to fix his DORA metric? Thanks.

[klesh]

@kostas-petrakis Here you are, new beta release with your fix. https://github.com/apache/incubator-devlake/releases/tag/v1.0.2-beta8